usb: gadget: f_fs: Fix race between aio_cancel() and AIO request complete
In the Linux kernel, the following vulnerability has been resolved: usb: gadget: f_fs: Fix race between aio_cancel() and AIO request complete FFS based applications can utilize the aio_cancel() callback to dequeue pending USB requests submitted to the UDC. There is a scenario where the FFS application issues an AIO cancel call, while the UDC is handling a soft disconnect. For a DWC3 based implementation, the callstack looks like the following: DWC3 Gadget FFS Application dwc3_gadget_soft_disconnect() ... --> dwc3_stop_active_transfers() --> dwc3_gadget_giveback(-ESHUTDOWN) --> ffs_epfile_async_io_complete() ffs_aio_cancel() --> usb_ep_free_request() --> usb_ep_dequeue() There is currently no locking implemented between the AIO completion handler and AIO cancel, so the issue occurs if the completion routine is running in parallel to an AIO cancel call coming from the FFS application. As the completion call frees the USB request (io_data->req) the FFS application is also referencing it for the usb_ep_dequeue() call. This can lead to accessing a stale/hanging pointer. commit b566d38857fc ("usb: gadget: f_fs: use io_data->status consistently") relocated the usb_ep_free_request() into ffs_epfile_async_io_complete(). However, in order to properly implement locking to mitigate this issue, the spinlock can't be added to ffs_epfile_async_io_complete(), as usb_ep_dequeue() (if successfully dequeuing a USB request) will call the function driver's completion handler in the same context.
CVE-2024-36894
Primary source · Revision 1
Imported from structured advisory data. Source references identify upstream records or fields; verify affected versions and your deployed configuration.
Security context
Source reference: cve:CVE-2024-36894
Linux
Source reference: /containers/cna/affected/0/product
- Affected versions
- Not stated in this record
- Fixed versions
- Not stated in this record
- Prerequisites
- Not stated in this record
Linux
Source reference: /containers/cna/affected/1/product
- Affected versions
- Not stated in this record
- Fixed versions
- Not stated in this record
- Prerequisites
- Not stated in this record
Structured affected-version data
Original package identities and version rules from this source.
[
{
"repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
"vendor": "Linux",
"product": "Linux",
"versions": [
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "f71a53148ce34898fef099b75386a3a9f4449311",
"versionType": "git"
},
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "9e72ef59cbe61cd1243857a6418ca92104275867",
"versionType": "git"
},
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "e500b1c4e29ad0bd1c1332a1eaea2913627a92dd",
"versionType": "git"
},
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "3613e5023f09b3308545e9d1acda86017ebd418a",
"versionType": "git"
},
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "a0fdccb1c9e027e3195f947f61aa87d6d0d2ea14",
"versionType": "git"
},
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "73c05ad46bb4fbbdb346004651576d1c8dbcffbb",
"versionType": "git"
},
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "d7461830823242702f5d84084bcccb25159003f4",
"versionType": "git"
},
{
"status": "affected",
"version": "2e4c7553cd6f9c68bb741582dcb614edcbeca70f",
"lessThan": "24729b307eefcd7c476065cd7351c1a018082c19",
"versionType": "git"
}
],
"programFiles": [
"drivers/usb/gadget/function/f_fs.c"
],
"defaultStatus": "unaffected"
},
{
"repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
"vendor": "Linux",
"product": "Linux",
"versions": [
{
"status": "affected",
"version": "3.15"
},
{
"status": "unaffected",
"version": "0",
"lessThan": "3.15",
"versionType": "semver"
},
{
"status": "unaffected",
"version": "4.19.317",
"versionType": "semver",
"lessThanOrEqual": "4.19.*"
},
{
"status": "unaffected",
"version": "5.4.279",
"versionType": "semver",
"lessThanOrEqual": "5.4.*"
},
{
"status": "unaffected",
"version": "5.10.221",
"versionType": "semver",
"lessThanOrEqual": "5.10.*"
},
{
"status": "unaffected",
"version": "5.15.162",
"versionType": "semver",
"lessThanOrEqual": "5.15.*"
},
{
"status": "unaffected",
"version": "6.1.95",
"versionType": "semver",
"lessThanOrEqual": "6.1.*"
},
{
"status": "unaffected",
"version": "6.6.31",
"versionType": "semver",
"lessThanOrEqual": "6.6.*"
},
{
"status": "unaffected",
"version": "6.8.10",
"versionType": "semver",
"lessThanOrEqual": "6.8.*"
},
{
"status": "unaffected",
"version": "6.9",
"versionType": "original_commit_for_fix",
"lessThanOrEqual": "*"
}
],
"programFiles": [
"drivers/usb/gadget/function/f_fs.c"
],
"defaultStatus": "affected"
}
]- Related CVEs
- CVE-2024-36894
Source reference:
/cveMetadata/cveId
Publisher severity
high
Source reference: /containers/cna/metrics
- Event
- #26582 · Revision 1
- Added to Heist Feed
- Publisher date