can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate
In the Linux kernel, the following vulnerability has been resolved: can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate The conclusion "j1939_session_deactivate() should be called with a session ref-count of at least 2" is incorrect. In some concurrent scenarios, j1939_session_deactivate can be called with the session ref-count less than 2. But there is not any problem because it will check the session active state before session putting in j1939_session_deactivate_locked(). Here is the concurrent scenario of the problem reported by syzbot and my reproduction log. cpu0 cpu1 j1939_xtp_rx_eoma j1939_xtp_rx_abort_one j1939_session_get_by_addr [kref == 2] j1939_session_get_by_addr [kref == 3] j1939_session_deactivate [kref == 2] j1939_session_put [kref == 1] j1939_session_completed j1939_session_deactivate WARN_ON_ONCE(kref < 2) ===================================================== WARNING: CPU: 1 PID: 21 at net/can/j1939/transport.c:1088 j1939_session_deactivate+0x5f/0x70 CPU: 1 PID: 21 Comm: ksoftirqd/1 Not tainted 5.14.0-rc7+ #32 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1 04/01/2014 RIP: 0010:j1939_session_deactivate+0x5f/0x70 Call Trace: j1939_session_deactivate_activate_next+0x11/0x28 j1939_xtp_rx_eoma+0x12a/0x180 j1939_tp_recv+0x4a2/0x510 j1939_can_recv+0x226/0x380 can_rcv_filter+0xf8/0x220 can_receive+0x102/0x220 ? process_backlog+0xf0/0x2c0 can_rcv+0x53/0xf0 __netif_receive_skb_one_core+0x67/0x90 ? process_backlog+0x97/0x2c0 __
CVE-2021-4454
Primary source · Revision 1
Imported from structured advisory data. Source references identify upstream records or fields; verify affected versions and your deployed configuration.
Security context
Source reference: cve:CVE-2021-4454
Linux
Source reference: /containers/cna/affected/0/product
- Affected versions
- Not stated in this record
- Fixed versions
- Not stated in this record
- Prerequisites
- Not stated in this record
Linux
Source reference: /containers/cna/affected/1/product
- Affected versions
- Not stated in this record
- Fixed versions
- Not stated in this record
- Prerequisites
- Not stated in this record
Structured affected-version data
Original package identities and version rules from this source.
[
{
"repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
"vendor": "Linux",
"product": "Linux",
"versions": [
{
"status": "affected",
"version": "7eef18c0479ba5d9f54fba30cd77c233ebca3eb1",
"lessThan": "6950df42a03c9ac9290503ced3f371199cb68fa9",
"versionType": "git"
},
{
"status": "affected",
"version": "55dd22c5d029423f513fd849e633adf0e9c10d0c",
"lessThan": "b6d44072117bba057d50f7a2f96e5d070c65926d",
"versionType": "git"
},
{
"status": "affected",
"version": "0c71437dd50dd687c15d8ca80b3b68f10bb21d63",
"lessThan": "9ab896775f98ff54b68512f345eed178bf961084",
"versionType": "git"
},
{
"status": "affected",
"version": "0c71437dd50dd687c15d8ca80b3b68f10bb21d63",
"lessThan": "1740a1e45eee65099a92fb502e1e67e63aad277d",
"versionType": "git"
},
{
"status": "affected",
"version": "0c71437dd50dd687c15d8ca80b3b68f10bb21d63",
"lessThan": "d0553680f94c49bbe0e39eb50d033ba563b4212d",
"versionType": "git"
},
{
"status": "affected",
"version": "5e1fc537c1be332aef9621ca9146aeb3ba59522f",
"versionType": "git"
},
{
"status": "affected",
"version": "5.4.138",
"lessThan": "5.4.232",
"versionType": "semver"
},
{
"status": "affected",
"version": "5.10.56",
"lessThan": "5.10.168",
"versionType": "semver"
},
{
"status": "affected",
"version": "5.13.8",
"lessThan": "5.14",
"versionType": "semver"
}
],
"programFiles": [
"net/can/j1939/transport.c"
],
"defaultStatus": "unaffected"
},
{
"repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
"vendor": "Linux",
"product": "Linux",
"versions": [
{
"status": "affected",
"version": "5.14"
},
{
"status": "unaffected",
"version": "0",
"lessThan": "5.14",
"versionType": "semver"
},
{
"status": "unaffected",
"version": "5.4.232",
"versionType": "semver",
"lessThanOrEqual": "5.4.*"
},
{
"status": "unaffected",
"version": "5.10.168",
"versionType": "semver",
"lessThanOrEqual": "5.10.*"
},
{
"status": "unaffected",
"version": "5.15.93",
"versionType": "semver",
"lessThanOrEqual": "5.15.*"
},
{
"status": "unaffected",
"version": "6.1.11",
"versionType": "semver",
"lessThanOrEqual": "6.1.*"
},
{
"status": "unaffected",
"version": "6.2",
"versionType": "original_commit_for_fix",
"lessThanOrEqual": "*"
}
],
"programFiles": [
"net/can/j1939/transport.c"
],
"defaultStatus": "affected"
}
]- Related CVEs
- CVE-2021-4454
Source reference:
/cveMetadata/cveId
Publisher severity
high
Source reference: /containers/cna/metrics
- Event
- #30176 · Revision 1
- Added to Heist Feed
- Publisher date