wireguard: netlink: check for dangling peer via is_dead instead of empty list
In the Linux kernel, the following vulnerability has been resolved: wireguard: netlink: check for dangling peer via is_dead instead of empty list If all peers are removed via wg_peer_remove_all(), rather than setting peer_list to empty, the peer is added to a temporary list with a head on the stack of wg_peer_remove_all(). If a netlink dump is resumed and the cursored peer is one that has been removed via wg_peer_remove_all(), it will iterate from that peer and then attempt to dump freed peers. Fix this by instead checking peer->is_dead, which was explictly created for this purpose. Also move up the device_update_lock lockdep assertion, since reading is_dead relies on that. It can be reproduced by a small script like: echo "Setting config..." ip link add dev wg0 type wireguard wg setconf wg0 /big-config ( while true; do echo "Showing config..." wg showconf wg0 > /dev/null done ) & sleep 4 wg setconf wg0 <(printf "[Peer]\nPublicKey=$(wg genkey)\n") Resulting in: BUG: KASAN: slab-use-after-free in __lock_acquire+0x182a/0x1b20 Read of size 8 at addr ffff88811956ec70 by task wg/59 CPU: 2 PID: 59 Comm: wg Not tainted 6.8.0-rc2-debug+ #5 Call Trace: dump_stack_lvl+0x47/0x70 print_address_description.constprop.0+0x2c/0x380 print_report+0xab/0x250 kasan_report+0xba/0xf0 __lock_acquire+0x182a/0x1b20 lock_acquire+0x191/0x4b0 down_read+0x80/0x440 get_peer+0x140/0xcb0 wg_get_device_dump+0x471/0x1130
CVE-2024-26951
Primary source · Revision 1
Imported from structured advisory data. Source references identify upstream records or fields; verify affected versions and your deployed configuration.
Security context
Source reference: cve:CVE-2024-26951
Linux
Source reference: /containers/cna/affected/0/product
- Affected versions
- Not stated in this record
- Fixed versions
- Not stated in this record
- Prerequisites
- Not stated in this record
Linux
Source reference: /containers/cna/affected/1/product
- Affected versions
- Not stated in this record
- Fixed versions
- Not stated in this record
- Prerequisites
- Not stated in this record
Structured affected-version data
Original package identities and version rules from this source.
[
{
"repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
"vendor": "Linux",
"product": "Linux",
"versions": [
{
"status": "affected",
"version": "e7096c131e5161fa3b8e52a650d7719d2857adfd",
"lessThan": "f52be46e3e6ecefc2539119784324f0cbc09620a",
"versionType": "git"
},
{
"status": "affected",
"version": "e7096c131e5161fa3b8e52a650d7719d2857adfd",
"lessThan": "710a177f347282eea162aec8712beb1f42d5ad87",
"versionType": "git"
},
{
"status": "affected",
"version": "e7096c131e5161fa3b8e52a650d7719d2857adfd",
"lessThan": "b7cea3a9af0853fdbb1b16633a458f991dde6aac",
"versionType": "git"
},
{
"status": "affected",
"version": "e7096c131e5161fa3b8e52a650d7719d2857adfd",
"lessThan": "13d107794304306164481d31ce33f8fdb25a9c04",
"versionType": "git"
},
{
"status": "affected",
"version": "e7096c131e5161fa3b8e52a650d7719d2857adfd",
"lessThan": "7bedfe4cfa38771840a355970e4437cd52d4046b",
"versionType": "git"
},
{
"status": "affected",
"version": "e7096c131e5161fa3b8e52a650d7719d2857adfd",
"lessThan": "302b2dfc013baca3dea7ceda383930d9297d231d",
"versionType": "git"
},
{
"status": "affected",
"version": "e7096c131e5161fa3b8e52a650d7719d2857adfd",
"lessThan": "55b6c738673871c9b0edae05d0c97995c1ff08c4",
"versionType": "git"
}
],
"programFiles": [
"drivers/net/wireguard/netlink.c"
],
"defaultStatus": "unaffected"
},
{
"repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
"vendor": "Linux",
"product": "Linux",
"versions": [
{
"status": "affected",
"version": "5.6"
},
{
"status": "unaffected",
"version": "0",
"lessThan": "5.6",
"versionType": "semver"
},
{
"status": "unaffected",
"version": "5.10.215",
"versionType": "semver",
"lessThanOrEqual": "5.10.*"
},
{
"status": "unaffected",
"version": "5.15.154",
"versionType": "semver",
"lessThanOrEqual": "5.15.*"
},
{
"status": "unaffected",
"version": "6.1.84",
"versionType": "semver",
"lessThanOrEqual": "6.1.*"
},
{
"status": "unaffected",
"version": "6.6.24",
"versionType": "semver",
"lessThanOrEqual": "6.6.*"
},
{
"status": "unaffected",
"version": "6.7.12",
"versionType": "semver",
"lessThanOrEqual": "6.7.*"
},
{
"status": "unaffected",
"version": "6.8.3",
"versionType": "semver",
"lessThanOrEqual": "6.8.*"
},
{
"status": "unaffected",
"version": "6.9",
"versionType": "original_commit_for_fix",
"lessThanOrEqual": "*"
}
],
"programFiles": [
"drivers/net/wireguard/netlink.c"
],
"defaultStatus": "affected"
}
]- Related CVEs
- CVE-2024-26951
Source reference:
/cveMetadata/cveId
Publisher severity
high
Source reference: /containers/cna/metrics
- Event
- #26466 · Revision 1
- Added to Heist Feed
- Publisher date