f2fs: fix to don't set SB_RDONLY in f2fs_handle_critical_error()

{
  "id": "61a0f118101280fdd641d6bce210d1e6a5f35e8a77cb241e8c282b552f8e17bd",
  "url": "https://osv.dev/vulnerability/CVE-2024-47689",
  "method": "structured",
  "payload": {
    "kind": "advisory",
    "title": "f2fs: fix to don't set SB_RDONLY in f2fs_handle_critical_error()",
    "summary": "In the Linux kernel, the following vulnerability has been resolved: f2fs: fix to don't set SB_RDONLY in f2fs_handle_critical_error() syzbot reports a f2fs bug as below: ------------[ cut here ]------------ WARNING: CPU: 1 PID: 58 at kernel/rcu/sync.c:177 rcu_sync_dtor+0xcd/0x180 kernel/rcu/sync.c:177 CPU: 1 UID: 0 PID: 58 Comm: kworker/1:2 Not tainted 6.10.0-syzkaller-12562-g1722389b0d86 #0 Workqueue: events destroy_super_work RIP: 0010:rcu_sync_dtor+0xcd/0x180 kernel/rcu/sync.c:177 Call Trace: percpu_free_rwsem+0x41/0x80 kernel/locking/percpu-rwsem.c:42 destroy_super_work+0xec/0x130 fs/super.c:282 process_one_work kernel/workqueue.c:3231 [inline] process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3312 worker_thread+0x86d/0xd40 kernel/workqueue.c:3390 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 As Christian Brauner pointed out [1]: the root cause is f2fs sets SB_RDONLY flag in internal function, rather than setting the flag covered w/ sb->s_umount semaphore via remount procedure, then below race condition causes this bug: - freeze_super() - sb_wait_write(sb, SB_FREEZE_WRITE) - sb_wait_write(sb, SB_FREEZE_PAGEFAULT) - sb_wait_write(sb, SB_FREEZE_FS) - f2fs_handle_critical_error - sb->s_flags |= SB_RDONLY - thaw_super - thaw_super_locked - sb_rdonly() is true, so it skips sb_freeze_unlock(sb, SB_FREEZE_FS) - deactivate_locked_super Since f2fs has almost the same log",
    "evidence": "osv:CVE-2024-47689",
    "products": [
      {
        "name": {
          "value": "Kernel",
          "evidence": "/affected/1/package/name"
        },
        "prerequisites": [],
        "fixed_versions": [
          {
            "value": "6.6.54",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.10.13",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.11.2",
            "evidence": "/affected/1/ranges"
          }
        ],
        "affected_versions": []
      }
    ],
    "severity": "unknown",
    "structured": {
      "id": "CVE-2024-47689",
      "aliases": [
        "CVE-2024-47689"
      ],
      "affected": [
        {
          "ranges": [
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "b62e71be2110d8b52bf5faf3c3ed7ca1a0c113a5"
                },
                {
                  "fixed": "649ec8b30df113042588bd3d3cd4e98bcb1091e0"
                },
                {
                  "fixed": "de43021c72993877a8f86f9fddfa0687609da5a4"
                },
                {
                  "fixed": "1f63f405c1a1a64b9c310388aad7055fb86b245c"
                },
                {
                  "fixed": "930c6ab93492c4b15436524e704950b364b2930c"
                }
              ]
            },
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "6.4.4"
                },
                {
                  "fixed": "6.5"
                }
              ]
            },
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "ed1d478bf838820201f3fb67a1748fdf15954ea4"
                }
              ]
            }
          ],
          "versions": [
            "v6.4.16",
            "v6.4.15",
            "v6.4.14",
            "v6.4.13",
            "v6.4.12",
            "v6.4.11",
            "v6.4.10",
            "v6.4.9",
            "v6.4.8",
            "v6.4.7",
            "v6.4.6",
            "v6.4.5",
            "v6.4.4"
          ],
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-47689.json"
          }
        },
        {
          "ranges": [
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.5.0"
                },
                {
                  "fixed": "6.6.54"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.7.0"
                },
                {
                  "fixed": "6.10.13"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.11.0"
                },
                {
                  "fixed": "6.11.2"
                }
              ]
            }
          ],
          "package": {
            "name": "Kernel",
            "ecosystem": "Linux"
          },
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-47689.json"
          }
        }
      ],
      "modified": "2026-10-28T02:30:32.814658142Z",
      "provider": "osv",
      "references": [
        "https://git.kernel.org/stable/c/1f63f405c1a1a64b9c310388aad7055fb86b245c",
        "https://git.kernel.org/stable/c/649ec8b30df113042588bd3d3cd4e98bcb1091e0",
        "https://git.kernel.org/stable/c/930c6ab93492c4b15436524e704950b364b2930c",
        "https://git.kernel.org/stable/c/de43021c72993877a8f86f9fddfa0687609da5a4",
        "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/47xxx/CVE-2024-47689.json",
        "https://nvd.nist.gov/vuln/detail/CVE-2024-47689",
        "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git"
      ],
      "provider_metadata": {
        "cna_assigner": "Linux",
        "osv_generated_from": "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/47xxx/CVE-2024-47689.json"
      }
    },
    "related_cves": [
      {
        "value": "CVE-2024-47689",
        "evidence": "/id"
      }
    ],
    "security_relevant": true,
    "severity_evidence": null
  },
  "source_id": "core-osv",
  "document_id": 499805,
  "published_at": "2024-10-21T11:53:29.185+00:00"
}