pinctrl: mcp23s08: Fix sleeping in atomic context due to regmap locking

{
  "id": "59ed9b66efa17e498bc203c0f962c3c5d1a95199ed8fc77587eb3d8bd606ac18",
  "url": "https://osv.dev/vulnerability/CVE-2024-57889",
  "method": "structured",
  "payload": {
    "kind": "advisory",
    "title": "pinctrl: mcp23s08: Fix sleeping in atomic context due to regmap locking",
    "summary": "In the Linux kernel, the following vulnerability has been resolved: pinctrl: mcp23s08: Fix sleeping in atomic context due to regmap locking If a device uses MCP23xxx IO expander to receive IRQs, the following bug can happen: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:283 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, ... preempt_count: 1, expected: 0 ... Call Trace: ... __might_resched+0x104/0x10e __might_sleep+0x3e/0x62 mutex_lock+0x20/0x4c regmap_lock_mutex+0x10/0x18 regmap_update_bits_base+0x2c/0x66 mcp23s08_irq_set_type+0x1ae/0x1d6 __irq_set_trigger+0x56/0x172 __setup_irq+0x1e6/0x646 request_threaded_irq+0xb6/0x160 ... We observed the problem while experimenting with a touchscreen driver which used MCP23017 IO expander (I2C). The regmap in the pinctrl-mcp23s08 driver uses a mutex for protection from concurrent accesses, which is the default for regmaps without .fast_io, .disable_locking, etc. mcp23s08_irq_set_type() calls regmap_update_bits_base(), and the latter locks the mutex. However, __setup_irq() locks desc->lock spinlock before calling these functions. As a result, the system tries to lock the mutex whole holding the spinlock. It seems, the internal regmap locks are not needed in this driver at all. mcp->lock seems to protect the regmap from concurrent accesses already, except, probably, in mcp_pinconf_get/set. mcp23s08_irq_set_type() and mcp23s08_irq_mask/unmask() are called under chip_bus_lock(), which calls mcp23s08_irq_bus_l",
    "evidence": "osv:CVE-2024-57889",
    "products": [
      {
        "name": {
          "value": "Kernel",
          "evidence": "/affected/1/package/name"
        },
        "prerequisites": [],
        "fixed_versions": [
          {
            "value": "5.4.289",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "5.10.233",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "5.15.176",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.1.124",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.6.70",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.12.9",
            "evidence": "/affected/1/ranges"
          }
        ],
        "affected_versions": []
      }
    ],
    "severity": "unknown",
    "structured": {
      "id": "CVE-2024-57889",
      "aliases": [
        "CVE-2024-57889"
      ],
      "affected": [
        {
          "ranges": [
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "8f38910ba4f662222157ce07a0d5becc4328c46a"
                },
                {
                  "fixed": "788d9e9a41b81893d6bb8faa05f045c975278318"
                },
                {
                  "fixed": "c55d186376a87b468c9ee30f2195e0f3857f61a0"
                },
                {
                  "fixed": "9372e160d8211a7e17f2abff8370794f182df785"
                },
                {
                  "fixed": "0310cbad163a908d09d99c26827859365cd71fcb"
                },
                {
                  "fixed": "8c6fd5803b988a5e78c9b9e42c70a936d7cfc6ec"
                },
                {
                  "fixed": "830f838589522404cd7c2f0f540602f25034af61"
                },
                {
                  "fixed": "a37eecb705f33726f1fb7cd2a67e514a15dfe693"
                }
              ]
            }
          ],
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-57889.json"
          }
        },
        {
          "ranges": [
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "4.13.0"
                },
                {
                  "fixed": "5.4.289"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "5.5.0"
                },
                {
                  "fixed": "5.10.233"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "5.11.0"
                },
                {
                  "fixed": "5.15.176"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "5.16.0"
                },
                {
                  "fixed": "6.1.124"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.2.0"
                },
                {
                  "fixed": "6.6.70"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.7.0"
                },
                {
                  "fixed": "6.12.9"
                }
              ]
            }
          ],
          "package": {
            "name": "Kernel",
            "ecosystem": "Linux"
          },
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-57889.json"
          }
        }
      ],
      "modified": "2026-10-28T02:30:33.012524182Z",
      "provider": "osv",
      "references": [
        "https://git.kernel.org/stable/c/0310cbad163a908d09d99c26827859365cd71fcb",
        "https://git.kernel.org/stable/c/788d9e9a41b81893d6bb8faa05f045c975278318",
        "https://git.kernel.org/stable/c/830f838589522404cd7c2f0f540602f25034af61",
        "https://git.kernel.org/stable/c/8c6fd5803b988a5e78c9b9e42c70a936d7cfc6ec",
        "https://git.kernel.org/stable/c/9372e160d8211a7e17f2abff8370794f182df785",
        "https://git.kernel.org/stable/c/a37eecb705f33726f1fb7cd2a67e514a15dfe693",
        "https://git.kernel.org/stable/c/c55d186376a87b468c9ee30f2195e0f3857f61a0",
        "https://lists.debian.org/debian-lts-announce/2025/03/msg00001.html",
        "https://lists.debian.org/debian-lts-announce/2025/03/msg00002.html",
        "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/57xxx/CVE-2024-57889.json",
        "https://nvd.nist.gov/vuln/detail/CVE-2024-57889",
        "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git"
      ],
      "provider_metadata": {
        "cna_assigner": "Linux",
        "osv_generated_from": "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/57xxx/CVE-2024-57889.json"
      }
    },
    "related_cves": [
      {
        "value": "CVE-2024-57889",
        "evidence": "/id"
      }
    ],
    "security_relevant": true,
    "severity_evidence": null
  },
  "source_id": "core-osv",
  "document_id": 499827,
  "published_at": "2025-01-15T13:05:41.769+00:00"
}