net/mlx5e: Fix mlx5e_priv_init() cleanup flow

{
  "id": "5d748e2a54d662a8a39eb6684c18eecddbc7cc41c638a0b47c7e49b63f3aae4a",
  "url": "https://osv.dev/vulnerability/CVE-2024-35959",
  "method": "structured",
  "payload": {
    "kind": "advisory",
    "title": "net/mlx5e: Fix mlx5e_priv_init() cleanup flow",
    "summary": "In the Linux kernel, the following vulnerability has been resolved: net/mlx5e: Fix mlx5e_priv_init() cleanup flow When mlx5e_priv_init() fails, the cleanup flow calls mlx5e_selq_cleanup which calls mlx5e_selq_apply() that assures that the `priv->state_lock` is held using lockdep_is_held(). Acquire the state_lock in mlx5e_selq_cleanup(). Kernel log: ============================= WARNING: suspicious RCU usage 6.8.0-rc3_net_next_841a9b5 #1 Not tainted ----------------------------- drivers/net/ethernet/mellanox/mlx5/core/en/selq.c:124 suspicious rcu_dereference_protected() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 2 locks held by systemd-modules/293: #0: ffffffffa05067b0 (devices_rwsem){++++}-{3:3}, at: ib_register_client+0x109/0x1b0 [ib_core] #1: ffff8881096c65c0 (&device->client_data_rwsem){++++}-{3:3}, at: add_client_context+0x104/0x1c0 [ib_core] stack backtrace: CPU: 4 PID: 293 Comm: systemd-modules Not tainted 6.8.0-rc3_net_next_841a9b5 #1 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 Call Trace: dump_stack_lvl+0x8a/0xa0 lockdep_rcu_suspicious+0x154/0x1a0 mlx5e_selq_apply+0x94/0xa0 [mlx5_core] mlx5e_selq_cleanup+0x3a/0x60 [mlx5_core] mlx5e_priv_init+0x2be/0x2f0 [mlx5_core] mlx5_rdma_setup_rn+0x7c/0x1a0 [mlx5_core] rdma_init_netdev+0x4e/0x80 [ib_core] ? mlx5_rdma_netdev_free+0x70/0x70 [mlx5_core] ipoib_intf_init+0x64/0x550 [ib_ipoib] ipoib_intf_alloc+0x4e/0xc0 [",
    "evidence": "osv:CVE-2024-35959",
    "products": [
      {
        "name": {
          "value": "Kernel",
          "evidence": "/affected/1/package/name"
        },
        "prerequisites": [],
        "fixed_versions": [
          {
            "value": "6.1.87",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.6.28",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.8.7",
            "evidence": "/affected/1/ranges"
          }
        ],
        "affected_versions": []
      }
    ],
    "severity": "unknown",
    "structured": {
      "id": "CVE-2024-35959",
      "aliases": [
        "CVE-2024-35959"
      ],
      "affected": [
        {
          "ranges": [
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "8bf30be75069d6080659de9a28565c048f6cef9b"
                },
                {
                  "fixed": "ad26f26abd353113dea4e8d5ebadccdab9b61e76"
                },
                {
                  "fixed": "f9ac93b6f3de34aa0bb983b9be4f69ca50fc70f3"
                },
                {
                  "fixed": "6bd77865fda662913dcb5722a66a773840370aa7"
                },
                {
                  "fixed": "ecb829459a841198e142f72fadab56424ae96519"
                }
              ]
            }
          ],
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-35959.json"
          }
        },
        {
          "ranges": [
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "5.18.0"
                },
                {
                  "fixed": "6.1.87"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.2.0"
                },
                {
                  "fixed": "6.6.28"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.7.0"
                },
                {
                  "fixed": "6.8.7"
                }
              ]
            }
          ],
          "package": {
            "name": "Kernel",
            "ecosystem": "Linux"
          },
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-35959.json"
          }
        }
      ],
      "modified": "2026-10-28T02:30:38.399020340Z",
      "provider": "osv",
      "references": [
        "https://git.kernel.org/stable/c/6bd77865fda662913dcb5722a66a773840370aa7",
        "https://git.kernel.org/stable/c/ad26f26abd353113dea4e8d5ebadccdab9b61e76",
        "https://git.kernel.org/stable/c/ecb829459a841198e142f72fadab56424ae96519",
        "https://git.kernel.org/stable/c/f9ac93b6f3de34aa0bb983b9be4f69ca50fc70f3",
        "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/35xxx/CVE-2024-35959.json",
        "https://nvd.nist.gov/vuln/detail/CVE-2024-35959",
        "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git"
      ],
      "provider_metadata": {
        "cna_assigner": "Linux",
        "osv_generated_from": "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/35xxx/CVE-2024-35959.json"
      }
    },
    "related_cves": [
      {
        "value": "CVE-2024-35959",
        "evidence": "/id"
      }
    ],
    "security_relevant": true,
    "severity_evidence": null
  },
  "source_id": "core-osv",
  "document_id": 505539,
  "published_at": "2024-05-20T09:41:51.244+00:00"
}