vdpa/mlx5: Fix release of uninitialized resources on error path

{
  "id": "664fd8b767232a4f2d738ebbe0196c8b05f69f9028f2cb59d73f548c99bc591b",
  "url": "https://osv.dev/vulnerability/CVE-2025-38628",
  "method": "structured",
  "payload": {
    "kind": "advisory",
    "title": "vdpa/mlx5: Fix release of uninitialized resources on error path",
    "summary": "In the Linux kernel, the following vulnerability has been resolved: vdpa/mlx5: Fix release of uninitialized resources on error path The commit in the fixes tag made sure that mlx5_vdpa_free() is the single entrypoint for removing the vdpa device resources added in mlx5_vdpa_dev_add(), even in the cleanup path of mlx5_vdpa_dev_add(). This means that all functions from mlx5_vdpa_free() should be able to handle uninitialized resources. This was not the case though: mlx5_vdpa_destroy_mr_resources() and mlx5_cmd_cleanup_async_ctx() were not able to do so. This caused the splat below when adding a vdpa device without a MAC address. This patch fixes these remaining issues: - Makes mlx5_vdpa_destroy_mr_resources() return early if called on uninitialized resources. - Moves mlx5_cmd_init_async_ctx() early on during device addition because it can't fail. This means that mlx5_cmd_cleanup_async_ctx() also can't fail. To mirror this, move the call site of mlx5_cmd_cleanup_async_ctx() in mlx5_vdpa_free(). An additional comment was added in mlx5_vdpa_free() to document the expectations of functions called from this context. Splat: mlx5_core 0000:b5:03.2: mlx5_vdpa_dev_add:3950:(pid 2306) warning: No mac address provisioned? ------------[ cut here ]------------ WARNING: CPU: 13 PID: 2306 at kernel/workqueue.c:4207 __flush_work+0x9a/0xb0 [...] Call Trace: ? __try_to_del_timer_sync+0x61/0x90 ? __timer_delete_sync+0x2b/0x40 mlx5_vdpa_destroy_mr_resources+0x1c/0x40 [mlx5_vdpa] mlx5_vdpa_free+0x45",
    "evidence": "osv:CVE-2025-38628",
    "products": [
      {
        "name": {
          "value": "Kernel",
          "evidence": "/affected/1/package/name"
        },
        "prerequisites": [],
        "fixed_versions": [
          {
            "value": "6.12.42",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.15.10",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.16.1",
            "evidence": "/affected/1/ranges"
          }
        ],
        "affected_versions": []
      }
    ],
    "severity": "unknown",
    "structured": {
      "id": "CVE-2025-38628",
      "aliases": [
        "CVE-2025-38628"
      ],
      "affected": [
        {
          "ranges": [
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "83e445e64f48bdae3f25013e788fcf592f142576"
                },
                {
                  "fixed": "37f26b9013b46457b0a96633fc3a7dc977d8beb1"
                },
                {
                  "fixed": "cf4fc23d0d3d5b89b36f0d79f2674510bb574d8e"
                },
                {
                  "fixed": "6de4ef950dd56a6a81daf92d8a1d864fc6a56971"
                },
                {
                  "fixed": "cc51a66815999afb7e9cd845968de4fdf07567b7"
                }
              ]
            }
          ],
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2025-38628.json"
          }
        },
        {
          "ranges": [
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.12.0"
                },
                {
                  "fixed": "6.12.42"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.13.0"
                },
                {
                  "fixed": "6.15.10"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.16.0"
                },
                {
                  "fixed": "6.16.1"
                }
              ]
            }
          ],
          "package": {
            "name": "Kernel",
            "ecosystem": "Linux"
          },
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2025-38628.json"
          }
        }
      ],
      "modified": "2026-10-28T02:30:38.735763557Z",
      "provider": "osv",
      "references": [
        "https://git.kernel.org/stable/c/37f26b9013b46457b0a96633fc3a7dc977d8beb1",
        "https://git.kernel.org/stable/c/6de4ef950dd56a6a81daf92d8a1d864fc6a56971",
        "https://git.kernel.org/stable/c/cc51a66815999afb7e9cd845968de4fdf07567b7",
        "https://git.kernel.org/stable/c/cf4fc23d0d3d5b89b36f0d79f2674510bb574d8e",
        "https://github.com/CVEProject/cvelistV5/tree/main/cves/2025/38xxx/CVE-2025-38628.json",
        "https://nvd.nist.gov/vuln/detail/CVE-2025-38628",
        "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git"
      ],
      "provider_metadata": {
        "cna_assigner": "Linux",
        "osv_generated_from": "https://github.com/CVEProject/cvelistV5/tree/main/cves/2025/38xxx/CVE-2025-38628.json"
      }
    },
    "related_cves": [
      {
        "value": "CVE-2025-38628",
        "evidence": "/id"
      }
    ],
    "security_relevant": true,
    "severity_evidence": null
  },
  "source_id": "core-osv",
  "document_id": 505966,
  "published_at": "2025-08-22T16:00:36.841+00:00"
}