ice: fix memory corruption bug with suspend and rebuild

{
  "id": "0bdaa9ba5786bb0d714bea48bc06fd4934dfc520e89ddabc8f101150050354ef",
  "url": "https://osv.dev/vulnerability/CVE-2024-35911",
  "method": "structured",
  "payload": {
    "kind": "advisory",
    "title": "ice: fix memory corruption bug with suspend and rebuild",
    "summary": "In the Linux kernel, the following vulnerability has been resolved: ice: fix memory corruption bug with suspend and rebuild The ice driver would previously panic after suspend. This is caused from the driver *only* calling the ice_vsi_free_q_vectors() function by itself, when it is suspending. Since commit b3e7b3a6ee92 (\"ice: prevent NULL pointer deref during reload\") the driver has zeroed out num_q_vectors, and only restored it in ice_vsi_cfg_def(). This further causes the ice_rebuild() function to allocate a zero length buffer, after which num_q_vectors is updated, and then the new value of num_q_vectors is used to index into the zero length buffer, which corrupts memory. The fix entails making sure all the code referencing num_q_vectors only does so after it has been reset via ice_vsi_cfg_def(). I didn't perform a full bisect, but I was able to test against 6.1.77 kernel and that ice driver works fine for suspend/resume with no panic, so sometime since then, this problem was introduced. Also clean up an un-needed init of a local variable in the function being modified. PANIC from 6.8.0-rc1: [1026674.915596] PM: suspend exit [1026675.664697] ice 0000:17:00.1: PTP reset successful [1026675.664707] ice 0000:17:00.1: 2755 msecs passed between update to cached PHC time [1026675.667660] ice 0000:b1:00.0: PTP reset successful [1026675.675944] ice 0000:b1:00.0: 2832 msecs passed between update to cached PHC time [1026677.137733] ixgbe 0000:31:00.0 ens787: NIC Link is Up 1 Gbps, Fl",
    "evidence": "osv:CVE-2024-35911",
    "products": [
      {
        "name": {
          "value": "Kernel",
          "evidence": "/affected/1/package/name"
        },
        "prerequisites": [],
        "fixed_versions": [
          {
            "value": "6.6.26",
            "evidence": "/affected/1/ranges"
          },
          {
            "value": "6.8.5",
            "evidence": "/affected/1/ranges"
          }
        ],
        "affected_versions": []
      }
    ],
    "severity": "unknown",
    "structured": {
      "id": "CVE-2024-35911",
      "aliases": [
        "CVE-2024-35911"
      ],
      "affected": [
        {
          "ranges": [
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "b3e7b3a6ee92ab927f750a6b19615ce88ece808f"
                },
                {
                  "fixed": "e40a02f06ceb0e0b0183e0b973ac5dbf8f75edec"
                },
                {
                  "fixed": "11ff8392943e08a35cb0aa19d638b02db745f170"
                },
                {
                  "fixed": "1cb7fdb1dfde1aab66780b4ba44dba6402172111"
                }
              ]
            },
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "6.4.7"
                },
                {
                  "fixed": "6.5"
                }
              ]
            },
            {
              "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
              "type": "GIT",
              "events": [
                {
                  "introduced": "ca03b327224ed6be2d07f42ee6ee1cdd586cfd5b"
                }
              ]
            }
          ],
          "versions": [
            "v6.4.16",
            "v6.4.15",
            "v6.4.14",
            "v6.4.13",
            "v6.4.12",
            "v6.4.11",
            "v6.4.10",
            "v6.4.9",
            "v6.4.8",
            "v6.4.7"
          ],
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-35911.json"
          }
        },
        {
          "ranges": [
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.5.0"
                },
                {
                  "fixed": "6.6.26"
                }
              ]
            },
            {
              "type": "ECOSYSTEM",
              "events": [
                {
                  "introduced": "6.7.0"
                },
                {
                  "fixed": "6.8.5"
                }
              ]
            }
          ],
          "package": {
            "name": "Kernel",
            "ecosystem": "Linux"
          },
          "database_specific": {
            "source": "https://storage.googleapis.com/cve-osv-conversion/osv-output/CVE-2024-35911.json"
          }
        }
      ],
      "modified": "2026-10-28T02:30:26.163774603Z",
      "provider": "osv",
      "references": [
        "https://git.kernel.org/stable/c/11ff8392943e08a35cb0aa19d638b02db745f170",
        "https://git.kernel.org/stable/c/1cb7fdb1dfde1aab66780b4ba44dba6402172111",
        "https://git.kernel.org/stable/c/e40a02f06ceb0e0b0183e0b973ac5dbf8f75edec",
        "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/35xxx/CVE-2024-35911.json",
        "https://nvd.nist.gov/vuln/detail/CVE-2024-35911",
        "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git"
      ],
      "provider_metadata": {
        "cna_assigner": "Linux",
        "osv_generated_from": "https://github.com/CVEProject/cvelistV5/tree/main/cves/2024/35xxx/CVE-2024-35911.json"
      }
    },
    "related_cves": [
      {
        "value": "CVE-2024-35911",
        "evidence": "/id"
      }
    ],
    "security_relevant": true,
    "severity_evidence": null
  },
  "source_id": "core-osv",
  "document_id": 492747,
  "published_at": "2024-05-19T08:35:04.299+00:00"
}